negative numbers as properties should not parse as a list #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riflio
pushed a commit
to Riflio/lua-yaml
that referenced
this pull request
Jan 30, 2023
feat(yaml.lua): Add support check YAML version tag feat(yaml.lua): dump to yaml (author @snowyu, PR exosite#12) fix(yaml.lua): negative numbers as properties should not parse as a list (author @FreeMasen, PR exosite#11) fix(yaml.lua): timestamp timezone fix(yaml.lua): only parsing first block hash with indent==0 fix(yaml.lua): parsing block after empty row feat(samples): Check comments fix(samples): timezone feat(samples): Check negative numbers as properties
snowyu
pushed a commit
to snowyu/lua-yaml
that referenced
this pull request
Feb 2, 2023
feat(yaml.lua): Add support check YAML version tag feat(yaml.lua): dump to yaml (author @snowyu, PR exosite#12) fix(yaml.lua): negative numbers as properties should not parse as a list (author @FreeMasen, PR exosite#11) fix(yaml.lua): timestamp timezone fix(yaml.lua): only parsing first block hash with indent==0 fix(yaml.lua): parsing block after empty row feat(samples): Check comments fix(samples): timezone feat(samples): Check negative numbers as properties
tionis
pushed a commit
to tionis/lua-yaml
that referenced
this pull request
Dec 1, 2023
…k YAML version tag feat(yaml.lua): dump to yaml (author @snowyu, PR exosite#12) fix(yaml.lua): negative numbers as properties should not parse as a list (author @FreeMasen, PR exosite#11) fix(yaml.lua): timestamp timezone fix(yaml.lua): only parsing first block hash with indent==0 fix(yaml.lua): parsing block after empty row feat(samples): Check comments fix(samples): timezone feat(samples): Check negative numbers as properties Signed-off-by: tionis <git@tionis.dev>
tionis
pushed a commit
to tionis/lua-yaml
that referenced
this pull request
Dec 1, 2023
…k YAML version tag feat(yaml.lua): dump to yaml (author @snowyu, PR exosite#12) fix(yaml.lua): negative numbers as properties should not parse as a list (author @FreeMasen, PR exosite#11) fix(yaml.lua): timestamp timezone fix(yaml.lua): only parsing first block hash with indent==0 fix(yaml.lua): parsing block after empty row feat(samples): Check comments fix(samples): timezone feat(samples): Check negative numbers as properties Signed-off-by: tionis <git@tionis.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative numbers as properties are currently being tokenized into two parts, the
-and thestringand since the-isn't white space aware, it causes these values to end up as alist.This change adds a new case for
stringthat will consider any-not followed by a space. I had initially tried only capture the-%dcase but that lead to errors in the list-nested test. If desired I can keep working on restricting this further to valid numbers.