Skip to content

fix(macro): identifier-related bugs #536 #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kakserpom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(macro): identifier-related bugs #536 #616

kakserpom wants to merge 1 commit into from
+434 −58

Conversation

@kakserpom
Copy link
Contributor

@kakserpom kakserpom commented Dec 18, 2025

Fixes #536

@coveralls
Copy link

coveralls commented Dec 18, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20415056075

Details

  • 61 of 92 (66.3%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 36.729%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/extern_.rs 0 1 0.0%
crates/macros/src/zval.rs 0 2 0.0%
crates/macros/src/function.rs 1 6 16.67%
crates/macros/src/impl_.rs 0 6 0.0%
crates/macros/src/parsing.rs 31 37 83.78%
crates/macros/src/class.rs 4 15 26.67%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/function.rs 1 25.0%
Totals Coverage Status
Change from base Build 20412913109: 0.6%
Covered Lines: 1727
Relevant Lines: 4702
💛 - Coveralls

@kakserpom kakserpom changed the title bugfix(macro): identifier-related bugs #536 fix(macro): identifier-related bugs #536 Dec 18, 2025
@kakserpom kakserpom force-pushed the 536_identifiers branch 3 times, most recently from 9661e65 to a79af4e Compare December 21, 2025 15:42
ptondereau
ptondereau requested changes Dec 21, 2025
View reviewed changes
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking, but nice PR!

kakserpom added a commit to kakserpom/ext-php-rs that referenced this pull request Dec 21, 2025
@kakserpom @claude
fix(macro): address PR review feedback extphprs#616
9fde1b8 
- Remove 'resource' and 'numeric' from PHP_TYPE_KEYWORDS as they are
  allowed for class names per PHP source code
- Add EnumCase validation to prevent reserved keywords like 'true'/'false'
  from being used as enum case names
- Replace assert! with syn::Error for proper macro error handling with
  span information for better error messages

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ptondereau ptondereau ptondereau requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

macros: raw identifier bug

3 participants

@kakserpom @coveralls @ptondereau