Skip to content

Conversation

@kakserpom
Copy link
Contributor

Implements #310

@kakserpom kakserpom force-pushed the 310_performance branch 4 times, most recently from aea34a4 to 2bad259 Compare December 20, 2025 18:42
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly good from my point of view! Thank you for this PR

ptondereau
ptondereau previously approved these changes Dec 21, 2025
Copy link
Member

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@coveralls
Copy link

coveralls commented Dec 21, 2025

Pull Request Test Coverage Report for Build 20411452323

Details

  • 96 of 139 (69.06%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 37.651%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/args.rs 37 38 97.37%
benches/function_call.rs 0 6 0.0%
src/types/callable.rs 52 58 89.66%
crates/macros/src/function.rs 0 30 0.0%
Totals Coverage Status
Change from base Build 20411090076: 1.6%
Covered Lines: 1779
Relevant Lines: 4725

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants