Skip to content

Conversation

@DuncSmith
Copy link
Contributor

@DuncSmith DuncSmith commented Dec 23, 2025

This PR pins all GitHub Actions to specific commit SHAs for improved security and stability.

Why pin Actions to SHAs?

Using commit SHAs instead of tags or branch names provides several security and stability benefits:

  • Security: Prevents potential supply-chain attacks where an action's tag could be moved to malicious code
  • Immutability: Ensures the exact same code runs every time, even if tags are moved or deleted
  • Auditability: Makes it clear exactly which version of each action is being used
  • Stability: Prevents unexpected breaking changes from tag updates

Implementation

  • This change uses pinact to automatically pin actions while maintaining human-readable comments showing the original tag reference.
  • If required, a Dependabot configuration has also been added/updated to keep the pinned actions up to date.
  • If required, a GitHub Actions workflow has been added to check that all actions are pinned in future changes.
  • Shared workflows from fac/[ops-]shared-workflows on the main branch are intentionally excluded from pinning.

Part of https://github.com/fac/dev-platform/issues/2605

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DuncSmith DuncSmith marked this pull request as ready for review December 23, 2025 11:17
@DuncSmith DuncSmith requested a review from a team as a code owner December 23, 2025 11:17
@DuncSmith DuncSmith merged commit 0fbe6d7 into main Dec 23, 2025
8 checks passed
@DuncSmith DuncSmith deleted the devp/pin-action-shas branch December 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants