-
Notifications
You must be signed in to change notification settings - Fork 767
Remove Apache HTTP dependency #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
16afb25 to
62ab2f8
Compare
a4afe92 to
8d1fafb
Compare
|
I've updated the PR with the latest changes from |
5cb5ee8 to
66a1817
Compare
66a1817 to
fa49a0c
Compare
|
The PR has been updated with the latest changes from |
9afc477 to
27424fd
Compare
d1f8be5 to
4137058
Compare
3798ff6 to
a193710
Compare
b65d7bf to
ae23fcb
Compare
6278969 to
f57f8a8
Compare
e3a272e to
1a0cc84
Compare
|
@zielinskimz any chance to have a look at these PRs? |
77f308b to
f4a2557
Compare
|
@zielinskimz I've updated the PR to include the latest changes from |
f4a2557 to
9f50876
Compare
saifulrizal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are pleased to offer you the opportunity to compose a review. Your insights are greatly valued and will help others make informed decisions. Please take your time to share your experience. We appreciate your contribution to our community. Thank you for your willingness to provide feedback.
Summary
Apache HTTP classes have been removed from the Android SDK in Android 6.0. Developers needing these classes can add
useLibrary 'org.apache.http.legacy'to their Gradle file to keep using that library.Robolectric now provides shadows for this library in a separate module (
org.robolectric:shadows-httpclient), so it is no longer part of the main module.Changelog
Remove dependency on Apache HTTP.
Test Plan
As per CONTRIBUTING.md, I've ran
./gradlew test, but the task fails with the following message:Note that I have the same result from
master.