UserDirectory: Relax parsing for wfh-days pref #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original regex here only accepts the form "Thu, Fri". We should also accept "Thu,Fri" and "Thu Fri". By adding whitespace into the character class for the splitting, we consume any combination of commas and whitespace between arguments. This makes the parser more robust and user-friendly. Ticket: PLAT-3638
Member
|
Thanks, I have merged this, but also done a bit of refactoring so tests could be added. Through pre-existing faults, this did nothing to normalize order, to remove duplicates, etc. I've fixed a couple small things while doing the above. Your commit is present verbatim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original regex here only accepts the form "Thu, Fri". We should also accept "Thu,Fri" and "Thu Fri". By adding whitespace into the character class for the splitting, we consume any combination of commas and whitespace between arguments. This makes the parser more robust and user-friendly.
Ticket: PLAT-3638