Skip to content

Conversation

@omodei
Copy link
Member

@omodei omodei commented Sep 17, 2024

fix interface to new gammapy

@omodei omodei requested a review from ndilalla September 17, 2024 23:31
@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 50.67%. Comparing base (00a7fc5) to head (a59af22).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
fermipy/plotting.py 16.66% 5 Missing ⚠️
fermipy/gtanalysis.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   49.65%   50.67%   +1.02%     
==========================================
  Files         143      143              
  Lines       27191    27196       +5     
==========================================
+ Hits        13502    13782     +280     
+ Misses      13689    13414     -275     
Flag Coverage Δ
unittests 50.67% <53.84%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ndilalla
Copy link
Contributor

@omodei I updated the requirements relaxing the scipy and astropy dependencies and added a workflow to test against the development version of fermitools. Can you take a quick look? If you are okay, feel free to merge it!

@omodei omodei merged commit 4ccc314 into master Mar 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants