Skip to content

Conversation

@facero
Copy link
Contributor

@facero facero commented Mar 26, 2025

Hi,

This PR implements the DR4 catalog in the existing framework.
The PR adds the catalog gll_psc_v35 + new extended source archive (Extended_14years) + updates to the catalog.py. There are no new difference in the catalog format so this is pretty straightforward.
This PR fixes the issues raised in #607 and #632 .

It works locally.
@ndilalla tests are welcome !

contains the catalog gll_psc_v35 + new extended source archive (Extended_14years) + catalog.py update
There are no new difference in the catalog format
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 7.14286% with 52 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (4ccc314) to head (d4f5da5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fermipy/catalog.py 7.14% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   50.67%   50.58%   -0.09%     
==========================================
  Files         143      143              
  Lines       27196    27252      +56     
==========================================
+ Hits        13782    13786       +4     
- Misses      13414    13466      +52     
Flag Coverage Δ
unittests 50.58% <7.14%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@facero facero mentioned this pull request Mar 26, 2025
@ndilalla
Copy link
Contributor

Thanks @facero! I will merge this PR to the master and add a test for 4FGL-DR4

@ndilalla ndilalla self-requested a review March 26, 2025 16:46
@ndilalla ndilalla merged commit fe44283 into fermiPy:master Mar 26, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants