flamenco: vote states v4 #7608

mjain-jump · 2025-12-18T14:33:54Z

No description provided.

github-actions · 2025-12-18T21:01:16Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050658 s`	`0.050616 s`	`-0.083%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.623 s`	`1.638 s`	`0.924%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.658096 s`	`50.615552 s`	`-0.084%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

src/flamenco/runtime/program/fd_vote_program.c

src/flamenco/runtime/program/vote/Local.mk

src/flamenco/runtime/program/vote/fd_vote_state_versioned.h

ripatel-fd · 2025-12-19T17:53:45Z

src/flamenco/runtime/program/vote/fd_vote_state_versioned.h

+
+/**********************************************************************/
+/* Getters                                                            */
+/**********************************************************************/


I'd prefer to remove these banners and instead document the functions

tbh I'd prefer to keep these banners because it delineates the getters / setters cleanly without needing to explicitly document the exact same thing for every method in the file

src/flamenco/runtime/program/vote/fd_vote_state_versioned.h

src/flamenco/runtime/program/vote/fd_vote_state_versioned.c

src/flamenco/runtime/program/vote/fd_vote_state_v4.h

src/flamenco/runtime/program/vote/fd_vote_common.h

src/flamenco/runtime/program/vote/fd_vote_common.c

src/flamenco/runtime/program/vote/fd_authorized_voters.h

src/flamenco/runtime/program/vote/fd_authorized_voters.c

ripatel-fd

Looks good generally. Found some minor code style issues.
I'm rather concerned about object lifetime management and handling of tail-allocated variable size memory region. But these issues stem from fd_types and cannot trivially be fixed in the scope of this PR. Fuzzing will give us necessary confidence, but hope to make the deserialized vote state struct static size in the future.

github-actions · 2025-12-19T18:50:46Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050928 s`	`0.050838 s`	`-0.177%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.691 s`	`1.716 s`	`1.478%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.927636 s`	`50.837558 s`	`-0.177%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T17:41:57Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050561 s`	`0.050663 s`	`0.202%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.635 s`	`1.617 s`	`-1.101%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.561084 s`	`50.663427 s`	`0.202%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T18:37:47Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050715 s`	`0.0506 s`	`-0.227%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.642 s`	`1.674 s`	`1.949%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.715048 s`	`50.600215 s`	`-0.226%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T19:04:50Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050681 s`	`0.05057 s`	`-0.219%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.627 s`	`1.629 s`	`0.123%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.680843 s`	`50.569832 s`	`-0.219%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T19:32:30Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050577 s`	`0.050787 s`	`0.415%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.639 s`	`1.64 s`	`0.061%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.576744 s`	`50.786725 s`	`0.415%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T19:43:09Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050626 s`	`0.050632 s`	`0.012%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.603 s`	`1.614 s`	`0.686%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.625593 s`	`50.631777 s`	`0.012%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

github-actions · 2025-12-22T20:01:33Z

Performance Measurements ⏳

Suite	Baseline	New	Change
backtest `mainnet-368528500-perf` per slot	`0.050549 s`	`0.050694 s`	`0.287%` ✅
backtest `mainnet-368528500-perf` snapshot load	`1.625 s`	`1.614 s`	`-0.677%` ✅
backtest `mainnet-368528500-perf` total elapsed	`50.548703 s`	`50.693636 s`	`0.287%` ✅
`firedancer mem` usage with `mainnet.toml`	`1005.23 GiB`	`1005.23 GiB`	`0.000%` ✅

mjain-jump requested review from emwang-jump and lidatong as code owners December 18, 2025 14:33

mjain-jump force-pushed the mjain/rebased-vote-state-v3 branch 5 times, most recently from e8e5a94 to a43af0e Compare December 18, 2025 20:46

flamenco: vote states v4

b289efa

mjain-jump force-pushed the mjain/rebased-vote-state-v3 branch from a43af0e to b289efa Compare December 18, 2025 20:50