Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these two changes, tests pass.
The first change is some minor restructuring of the
run_plugintest helper to open files as context managers. This avoids an error related to writing to a closed file at L60.The second change is to vendor google/protobuf/descriptor.proto from its state as of August 2021 when the golden test output was generated. In the 4 years since then, many more messages and enums were added to descriptor.proto, so the test would fail:
But this snapshotted old edition fixes that.
This change is part of a trio. In combination with #18 and #19, github actions should go green again; this is working on my fork's 'actions' branch which merges the three: https://github.com/spenczar/protogen-python/actions/runs/15672639439/