Skip to content

Conversation

@spenczar
Copy link
Contributor

With these two changes, tests pass.

The first change is some minor restructuring of the run_plugin test helper to open files as context managers. This avoids an error related to writing to a closed file at L60.

The second change is to vendor google/protobuf/descriptor.proto from its state as of August 2021 when the golden test output was generated. In the 4 years since then, many more messages and enums were added to descriptor.proto, so the test would fail:

E           dependencies:
E           - name: google/api/http.proto
E             num_dependencies: 0
E             num_messages: 3
E             num_enums: 0
E             num_services: 0
E             num_extensions: 0
E           - name: google/protobuf/descriptor.proto
E             num_dependencies: 0
E         -   num_messages: 33
E         ?                 ^^
E         +   num_messages: 27
E         ?                 ^^
E         -   num_enums: 18
E         ?              ^^
E         +   num_enums: 6
E         ?              ^
E             num_services: 0
E             num_extensions: 0

But this snapshotted old edition fixes that.


This change is part of a trio. In combination with #18 and #19, github actions should go green again; this is working on my fork's 'actions' branch which merges the three: https://github.com/spenczar/protogen-python/actions/runs/15672639439/

spenczar added 2 commits June 15, 2025 22:29
The vendored copy is from 96307d28f69662eb04edcaeb9d1d1ed25e692d88
which is from Mar 22 2021.

This is rather old, but matches the golden test output - which
is the only real point of the vendored file.
This was referenced Jun 16, 2025
@fischor fischor merged commit 396e75f into fischor:main Jun 17, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants