Critical fix: Prevent engines from getting ember-ui postcssOptions #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes production build failures where engines try to compile CSS with ember-ui's import paths even though treeForStyles returns null. Problem: - included() hook runs BEFORE tree deduplication - Engines were getting postcssOptions with ember-ui import paths - treeForStyles returned null (no CSS files) - Engines tried to compile with imports that don't exist - clean-css failed: 'Broken @import declaration' Solution: - Detect if parent is an engine in included() - Return early without setting postcssOptions - Engines inherit postcssOptions from host app instead - Only host app gets ember-ui's postcss configuration Result: - ember-ui styles compiled once in host app - Engines don't try to recompile - No CSS duplication - Production builds succeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes production build failures where engines try to compile CSS with ember-ui's import paths even though treeForStyles returns null.
Problem:
Solution:
Result: