Skip to content

fix: expose lassoLongPressIndicatorParentElement #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flekschas merged 1 commit into from
Dec 13, 2024
Merged

fix: expose lassoLongPressIndicatorParentElement #205

flekschas merged 1 commit into from
Dec 13, 2024

Conversation

@flekschas
Copy link
Owner

@flekschas flekschas commented Dec 13, 2024

This PR exposes lassoLongPressIndicatorParentElement

Description

What was changed in this pull request?

E.g.: scatterplot.set({ lassoLongPressIndicatorParentElement: document.body })

Why is it necessary?

This can be useful for scenarios where the base element changes like entering full screen mode

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

@flekschas flekschas merged commit 6259d9a into main Dec 13, 2024
2 checks passed
@flekschas flekschas deleted the flekschas/expose-lasso-long-press-indicator-parent-element branch December 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flekschas