Skip to content

fix: improve brush selection #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flekschas merged 3 commits into from
Feb 13, 2025
Merged

fix: improve brush selection #217

flekschas merged 3 commits into from
Feb 13, 2025

Conversation

@flekschas
Copy link
Owner

@flekschas flekschas commented Feb 13, 2025

This PR improves the brush selection

Description

What was changed in this pull request?

  1. Loops don't negate the selection. I.e., points that fall within the overlapping area of a loop are properly selected
  2. Smooth the brush normal to avoid too jittery brush

Why is it necessary?

Because this is cool

Example

Screen.Recording.2025-02-13.at.9.03.47.AM.mp4

Checklist

  • Provided a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties")
  • CHANGELOG.md updated
  • Tests added or updated
  • Documentation in README.md added or updated
  • Example(s) added or updated
  • Screenshot, gif, or video attached for visual changes

@flekschas flekschas merged commit 0b3ce0b into main Feb 13, 2025
2 checks passed
@flekschas flekschas deleted the flekschas/improve-brush-selection branch February 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flekschas