Skip to content

fix(SyncProcess): Reduce size of continuation on disk #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marcelklehr wants to merge 52 commits into
base: develop
Choose a base branch
from
Open

fix(SyncProcess): Reduce size of continuation on disk #2140

marcelklehr wants to merge 52 commits into from

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 27, 2025

No description provided.

@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch 2 times, most recently from 0a35501 to 27d0699 Compare December 27, 2025 11:36
@marcelklehr
fix(SyncProcess): Reduce size of continuation on disk
54eb4f1 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(SyncProcess): Fix getmembersToPersist
658ef86 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(index): Update index incrementally instead of recreating it every…
3e1b4b9 
… time

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(continuation): Fix continuation loading
426a078 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from be09e21 to 426a078 Compare December 28, 2025 09:54
@marcelklehr
fix(Tree): Fix updateIndex and removeFromIndex
4a5d598 
don't throw if index doesn't exist

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Tree): Improve updateIndex
119f3a9 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(CachingTreeWrapper): Make sure item index is up to date for updat…
6914962 
…eIndex

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Tree): Fix incremental index updates
f7fb9b4 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(CachingAdapter): Fix incremental index updates
9512d18 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(CachingAdapter): Fix incremental index updates
b11a7b6 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(NextcloudBookmarks): Fix incremental index updates
545bddb 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(NextcloudBookmarks): Fix incremental index updates
b8b0436 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
tests: Don't close about:addons page in tab tests
9508bcd 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Tree): Fix end condition in removeFromIndex
71229e1 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from 501e589 to fa6ffaf Compare December 28, 2025 19:52
@marcelklehr
fix(LocalTabs): Poperly distinguish between window IDs and group IDs
e7bcdf4 
(important for mappings and tree index)

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from fa6ffaf to e7bcdf4 Compare December 28, 2025 21:16
@marcelklehr
fix(CachingTreeWrapper): Make sure to copy the tree
761955e 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Caching#orderFolder): Fix orderFolder algorithm
c069b1f 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(BrowserAccountStorage): Use setEntry instead of changeEntry
0fe68fe 
to reduce memory pressure

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Folder#toJSON): Make sure children are properly serialized
9c64fda 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(NextcloudBookmarks): Fix updateBookmark()
55c8a56 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from 0e4a096 to 55c8a56 Compare December 29, 2025 10:31
@marcelklehr
tests: Don't pass anonymous object into Adapter#updateBookmark
7af309b 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Diff): Do not call .toString on null, but use String()
110ed3c 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr requested a review from Copilot December 29, 2025 14:02
@marcelklehr
fix(SyncProcess): Simplify setProgress
2e5afd1 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Tree): Fix removeFromIndex to remove the entire subtree
b770ca8 
instead of just the ID of the item that was passed

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from 7ac0e1a to b770ca8 Compare December 29, 2025 16:03
@marcelklehr
fix(childrenSimilarity): Make O(n) instead of O(n²)
95fd68d 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Tree#hash): Use yieldToEventLoop to allow browser to breathe
7ffb269 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of findMoves to improve performance
2caffc5 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of diffFolder to improve perform…
3925e01 
…ance

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of findMoves
6eb984c 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of findMoves
da48e1d 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of findMoves
19ad39b 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Reduce time complexity of findMoves
01a4c7b 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Caching): Make sure that created bookmarks have the correct locat…
4423a3c 
…ion tag

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Unidirectional): Use source MOVEs for revertPlan instead of targe…
bf977ae 
…t MOVEs

since we're no longer using the Cache in Unidirectional it doesn't matter and is cleaner

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Unidirectional): Only do a single Scanner pass to improve perform…
fb55c67 
…ance

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): yieldToEventLoop less often
b9de31a 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Try to improve time complexity of Scanner
18c5354 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the fix/slim-down-continuation branch from 3665357 to 18c5354 Compare December 31, 2025 06:16
@marcelklehr
fix(Scanner): Use clone instead of copy
55c6891 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Try to speed up findMoves by using a single pass queue
e7bbfa9 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(persistence): Fix SyncProcess#toJSONAsync
12d3192 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Fix findMoves
b474464 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(Scanner): Fix findMoves by adding folder count to sorting
3998904 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Revert "fix(Scanner): Try to speed up findMoves by using a single pas…
7537d0e 
…s queue"

This reverts commit e7bbfa9

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Revert "fix(Scanner): Reduce time complexity of findMoves to improve …
204bf11 
…performance"

This reverts commit 2caffc5

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Fix: Reduce memory pressure by reducing ACTION_CONCURRENCY
c0c640c 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Reapply "fix(Scanner): Reduce time complexity of findMoves to improve…
3aad9e9 
… performance"

This reverts commit 204bf11.
@marcelklehr
Fix(Scanner#diffFolder): Fall back to O(n) strategy if fuzzy map does…
538d892 
…n't yield results

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Fix(Scanner): Go back to two-tiered algorithm with direct matches fir…
6ef3f3a 
…st, but keep fuzzy index

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(executeReorderings): Try to prevent crash
e5b4f5b 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
fix(SyncProcess): Fix serialization for continuation persistence
95ba6ba 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcelklehr