Skip to content

Conversation

@parlough
Copy link
Member

No description provided.

@parlough parlough force-pushed the misc/verdure-client-cleanup branch from b247ef5 to 663ddff Compare December 28, 2025 22:46
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on cleaning up the Verdure client example and updating dependencies. The changes include adopting modern Dart features like pattern matching, using the spacing property in Row and Column widgets for cleaner layouts, and updating Riverpod and related packages to newer versions. The code is generally improved and more maintainable. I've left a couple of minor suggestions for improvement. Please also note that the repository's style guide requires a Pre-Review Checklist in the PR description, which is currently missing.

Comment on lines 30 to 32
setState(() {
_initialRequestSent = true;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Calling setState within a ref.listen callback inside the build method is discouraged as it can lead to unexpected rebuilds. Since _initialRequestSent is a flag to prevent re-execution and doesn't directly affect the UI, you can update it without setState to avoid an unnecessary widget rebuild. You can replace these lines with a simple assignment:

_initialRequestSent = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant