Accept opts.server value in engine.js #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to provide values such as REQUEST_URI from express to the PHPExpress engine.
Author
|
Example application used to test REQUEST_URI: https://gist.github.com/Markavian/ff100dcba4f4580ec87865c3d12a1240 Tested this branch locally using |
arloduff
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests aims to allow additional environment variables to be passed to PHP from Express; explicitly including req.url mapped to REQUEST_URI to help PHP understand more about the request being served.
The change allows:
opts.serverto be provided to allow mapping betweenreq.url:REQUEST_URIfrom express to the PHPExpress engine