Skip to content

Conversation

@tstonis
Copy link

@tstonis tstonis commented Feb 7, 2015

I only tested this on socket.io v1.0, but looks like should also work with v0.9 (where used to be called a resource). I auto-synthesized the property - hope that's okay. I tested without a path and also with a path (going through nginx reverse proxy) and seems to work fine.

@francoisp
Copy link
Owner

Thanks a bunch for your contribution!
Keep them coming! Will merge on Monday,

Best,
F

Sent from my iPhone

On Feb 7, 2015, at 11:46 AM, tstonis notifications@github.com wrote:

I only tested this on socket.io v1.0, but looks like should also work with v0.9 (where used to be called a resource). I auto-synthesized the property - hope that's okay. I tested without a path and also with a path (going through nginx reverse proxy) and seems to work fine.

You can view, comment on, or merge this pull request online at:

#4

Commit Summary

Add support for a path in the URL
Add a default path of ""
File Changes

M SocketIO.h (1)
M SocketIO.m (11)
M SocketIOTransport.h (1)
M SocketIOTransportWebsocket.m (12)
M SocketIOTransportXHR.m (12)
Patch Links:

https://github.com/francoisp/socket.IO-objc/pull/4.patch
https://github.com/francoisp/socket.IO-objc/pull/4.diff

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants