Skip to content

Conversation

@ksnortum
Copy link
Contributor

@ksnortum ksnortum commented Dec 8, 2024

No description provided.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that you took the list from this convert-ly rule.

I wonder if we should rather remove these lines instead of comment them.
@PeterBjuhr @jeanas what do you think?

@ksnortum
Copy link
Contributor Author

I actually ran into two of them in the auto-complete function, then found the conversion rule as you said. I'm happy to remove the lines. I was just being "cowardly" in commenting them.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove old syntax instead of commenting it. Please remove the lines.
You should also remove bracketCloseSymbol. Thanks

@fedelibre
Copy link
Member

I think you have to git pull -r origin master in order to pass the CI checks.

@ksnortum
Copy link
Contributor Author

Sorry for the commit history. git rebase still frightens me.

@fedelibre fedelibre force-pushed the kjs-remove-unused-words branch from 8cdf9aa to 390dd28 Compare December 18, 2024 21:14
@fedelibre
Copy link
Member

I've cleaned up the git history and pushed it to your branch. It is now ready to be merged.

@fedelibre fedelibre merged commit 8816136 into frescobaldi:master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants