Add more robust logic to find the last Bar in a ScorePart #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids an AttributeError if the last object in a ScorePart's barlist is not a Bar. For example, \addlyrics blocks are represented by simple Python lists rather than Bar objects. Fixes #69.
This was referenced Aug 26, 2025
fedelibre
approved these changes
Sep 2, 2025
Member
fedelibre
left a comment
fedelibre
left a comment
There was a problem hiding this comment.
I've tested it and I confirm it fixes the issue
|
Thank you very much for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids an
AttributeErrorif the last object in aScorePart'sbarlistis not aBar. For example,\addlyricsblocks are represented by simple Pythonlists rather thanBarobjects.Fixes #69.