Skip to content

MusicXML: recognize \partial #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eoma wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MusicXML: recognize \partial #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869c012
MusicXML: recognize \partial
eoma Apr 7, 2017
0ce48f7
Add test for \partial
eoma Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ly/musicxml/lymus2musxml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,12 @@ def check_tuplet(self):

def Duration(self, duration):
"""A written duration"""

if isinstance(duration.parent(), ly.music.items.Partial):
# No need to handle the duration element for a \partial element
# unless barcheck should be implemented
return

if self.tempo:
self.mediator.new_tempo(duration.token, duration.tokens, *self.tempo)
self.tempo = ()
Expand Down Expand Up @@ -550,6 +556,10 @@ def LyricMode(self, lyricmode):
r"""A \lyricmode, \lyrics or \addlyrics expression."""
self.alt_mode = 'lyric'

def Partial(self, partial):
r"""A \partial node"""
pass

def Override(self, override):
r"""An \override command."""
self.override_key = ''
Expand Down
4 changes: 4 additions & 0 deletions tests/test_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ def test_tuplet():
compare_output('tuplet')


def test_partial():
compare_output('partial')


def ly_to_xml(filename):
"""Read Lilypond file and return XML string."""
writer = ly.musicxml.writer()
Expand Down
6 changes: 6 additions & 0 deletions tests/test_xml_files/partial.ly
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
\score {
\relative c' {
\partial 4 c8 c | d1 |
}
\layout{}
}
61 changes: 61 additions & 0 deletions tests/test_xml_files/partial.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 2.0 Partwise//EN"
"http://www.musicxml.org/dtds/partwise.dtd">
<score-partwise version="3.0">
<identification>
<encoding>
<software>python-ly 0.9.5</software>
<encoding-date>2017-04-07</encoding-date>
</encoding>
</identification>
<part-list>
<score-part id="P1">
<part-name />
</score-part>
</part-list>
<part id="P1">
<measure number="1">
<attributes>
<divisions>2</divisions>
<time symbol="common">
<beats>4</beats>
<beat-type>4</beat-type>
</time>
<clef>
<sign>G</sign>
<line>2</line>
</clef>
</attributes>
<note>
<pitch>
<step>C</step>
<octave>4</octave>
</pitch>
<duration>1</duration>
<voice>1</voice>
<type>eighth</type>
</note>
<note>
<pitch>
<step>C</step>
<octave>4</octave>
</pitch>
<duration>1</duration>
<voice>1</voice>
<type>eighth</type>
</note>
</measure>
<measure number="2">
<note>
<pitch>
<step>D</step>
<octave>4</octave>
</pitch>
<duration>8</duration>
<voice>1</voice>
<type>whole</type>
</note>
</measure>
<measure number="3" />
</part>
</score-partwise>