fix: Build issues using 'strict' mode in tsconfig #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SynergyMike
changed the title
zcbenz
approved these changes
Apr 19, 2025
Contributor
zcbenz
left a comment
zcbenz
left a comment
There was a problem hiding this comment.
Thanks for fixing this, it has been a long time headache for me to correctly export types.
Can you do a rebase on latest main? I added a change to run CI for pull requests.
SynergyMike
force-pushed
the
synergymike/update-ts-exports
branch
from
7e4e7eb to
1fa1a5a
Compare
Contributor
Author
|
No worries! Thank you for bringing this to Node 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In consuming projects with
strictmode enabled in theirtsconfig.json, they will experience issues compiling due to how typescript is resolving imports. Currently,index.d.tsis exportingnn,optimizers, andutilsfromlib/instead of fromdist/, which causes typescript to include those source files (instead of just the declaration files) during compilation/type-checking of the importing project.This change aims to remedy that by:
lib/index.tsto be included in the compilation outputtypesinpackage.jsonto point to the compilation outputlib/core.ts(which also accounts for the circular reference issues).d.tsfile for declaring the shape of the bindings import