added option to reset streaming connection in sampler #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our test case, we create a new streaming connection for every thread loop, which is used only in that exact loop. In long running tests we want to prevent unused streaming connections from filling up the memory, so we need to make sure the connections get closed after every loop (the response pattern unfortunately is too unreliable here). As a solution, we added the option "Reset streaming connection" to the sampler to close any existing streaming connection under the given name and create a new one.
Additionally, we moved initialization and shutdown of the ExecutorService to the testStarted/testEnded methods, as not shutting down the ExecutorService properly resulted in the JVM not exiting after the test had finished.