This repository was archived by the owner on Aug 20, 2019. It is now read-only.
Add Card Reader API support for Full Contact #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullcontact.gemspec
Outdated
Contributor
There was a problem hiding this comment.
This should be moved to a development dependency.
Contributor
|
Thanks for your contribution! I've added a few comments above. I'll test this out tomorrow and get back to you with any additional feedback. |
Author
|
thanks for the feedback, I've updated my master. |
Contributor
|
Reviewing this for inclusion in 0.8.0, will act by end of week. |
|
Can this get merged? Looking to also have CardReader functionality. |
|
👍 for merging this |
|
@Xorlev - Is there a reason this never got merged? |
|
+1 for merging this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic support for the Card Reader API http://www.fullcontact.com/developer/docs/card-reader/, specifically the View Requests method.
I have tested only the page parameter but the other parameters (returnedData, format, and diagnostics) should also be supported, although for the format parameter, it doesn't make sense to return XML as the existing gem expects JSON.
The Readme.md has been updated with sample usage.