[WIP][#18]Create user list #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klishevich
reviewed
Nov 15, 2019
| userSchema.set('timestamps', true); | ||
| const User = mongoose.model('User', userSchema); | ||
|
|
||
| export default User; |
Member
There was a problem hiding this comment.
Also often it is good to use Joi (https://github.com/hapijs/joi) for api request validation
Author
There was a problem hiding this comment.
Also often it is good to use Joi (https://github.com/hapijs/joi) for api request validation
DenisNazarenko
commented
Nov 22, 2019
| }); | ||
| userSchema.set('timestamps', true); | ||
|
|
||
| userSchema.methods.JoiValidate = (obj) => { |
Author
There was a problem hiding this comment.
@klishevich Майкл, как тебе такой вариан? Добавил метод, который можно вызывать при crud и обрабатывать.
Member
There was a problem hiding this comment.
@DenisNazarenko выглядит норм, теперь только осталось его вызывать при каждой операции. Он вроде ошибки должен нормально формировать, которые на клиента можно возвращать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #18