Skip to content

Fix deprecated settings usage and civix upgrade #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jitendrapurohit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecated settings usage and civix upgrade #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions api/v3/Contacts/Correctnamecasesjob.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ function contacts_correctnamecasesjob_correct_name_case(&$aName) {
*/
function civicrm_api3_contacts_correctnamecasesjob($params) {

$lastContactExaminedOffset = CRM_Core_BAO_Setting::getItem(CAPSCORRECT_EXTENSION_NAME, CAPSCORRECT_LAST_CONTACT_OFFSET);
$lastContactExaminedOffset = Civi::settings()->get(CAPSCORRECT_LAST_CONTACT_OFFSET);

// See if the returned value is NULL or negative
if ( $lastContactExaminedOffset === NULL || $lastContactExaminedOffset < 0 ) {
throw new API_Exception(/*errorMessage*/ 'Unable to complete scheduled job, the offset was not returned.', /*errorCode*/ 1);
Expand Down Expand Up @@ -106,14 +107,13 @@ function civicrm_api3_contacts_correctnamecasesjob($params) {
}
}
// Update the total contacts corrected setting value
$totalContactsCorrected = CRM_Core_BAO_Setting::getItem(CAPSCORRECT_EXTENSION_NAME, CAPSCORRECT_TOTAL_CONTACTS_CORRECTED);
$totalContactsCorrected = Civi::settings()->get(CAPSCORRECT_TOTAL_CONTACTS_CORRECTED);
$totalContactsCorrected += $contactsCorrectedThisRun;
CRM_Core_BAO_Setting::setItem($totalContactsCorrected, CAPSCORRECT_EXTENSION_NAME, CAPSCORRECT_TOTAL_CONTACTS_CORRECTED);
Civi::settings()->set(CAPSCORRECT_TOTAL_CONTACTS_CORRECTED, $totalContactsCorrected);

// Update the offset setting
$lastContactExaminedOffset += $getContactsApiResults['count'];
CRM_Core_BAO_Setting::setItem($lastContactExaminedOffset, CAPSCORRECT_EXTENSION_NAME, CAPSCORRECT_LAST_CONTACT_OFFSET);

Civi::settings()->set(CAPSCORRECT_LAST_CONTACT_OFFSET, $lastContactExaminedOffset);

// Return values array
$apiReturnValues = array(
Expand Down
Loading