Add integration tests to new simtools-prod image #1955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables integration testing for the simtools-prod Docker image by making the CI-integrationtests.yml workflow reusable and calling it from the build-simtools-prod.yml workflow. The implementation tests only the no_opt (non-AVX optimized) image variant, simplifies the environment configuration process, and adds support for downloading QGSjet tables that are not included in production images.
Key Changes:
- Made CI-integrationtests.yml reusable via
workflow_calltrigger with configurable container image and model versions - Added integration test execution to build-simtools-prod.yml workflow that runs after image build completes
- Simplified and refactored environment variable setup in integration tests by sourcing .env_template directly
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| docs/changes/1955.feature.md | Changelog entry documenting the new integration test capability for production images |
| docker/Dockerfile-simtools-prod | Added bzip2 package to support decompression of QGSjet tables during testing |
| .github/workflows/build-simtools-prod.yml | Added job outputs for no_opt tag, enabled PR builds, and integrated test-simtools-prod job calling CI-integrationtests.yml |
| .github/workflows/CI-integrationtests.yml | Converted workflow to support workflow_call trigger, added conditional logic for prod vs dev containers, simplified environment setup, and added QGSjet download step for prod images |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after merge of #1954
Add integration tests to new simtools production image.
no_optimage only (as there is no functionality to request a certain AVX CPU in the CI)Check this CI workflow for a typical build and test procedure.