Some quality of life improvements for PartitionDS
#159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, for example, allows the family to be printed, and so the record UF can also be printed.
The package is not loadable if the kernel extension is not compiled, so the code removed in this PR is never used. Perhaps it is a remnant of an older version of the package which was usable with the kernel extension not compiled.
The previous versions of PartitionDS seem to have been written imagining a future where there would be multiple representations of union-find data structures. However, at present there's only one, and so it's annoying to have to include the filter when constructing a PartitionDS. This does not change any of the existing behaviour, but allows PartitionDS to be called with a single argument: either the number of points, or the parts of a partition.
There is already the IteratorOfRootsOfPartitionDS, but sometimes we just want the roots as a list. This operation is essentially the same as IteratorOfRootsOfPartitionDS but without the overhead of the iterator code.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 95.08% 95.27% +0.18%
==========================================
Files 36 36
Lines 2729 2711 -18
Branches 110 110
==========================================
- Hits 2595 2583 -12
+ Misses 114 108 -6
Partials 20 20
🚀 New features to boost your workflow:
|
james-d-mitchell
changed the title
PartitionDS
fingolfin
approved these changes
Oct 14, 2025
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Thanks, looks good!
I'll merge and then make a release with this.
If you are interested, I'd also be happy to make you co-maintainer of this package (but I also understand if you have enough other things on your plate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.