419 global importer update #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All importers now use milestones, globalReferences and randomUUIDs. All importers now also have a separate "cellMetadata.ts" file containing all the added metadata fileds to the actual codex cells needed for the specific file importer.
It should work now hopefully
- Introduced `migration_hoistDocumentContextToNotebookMetadata` to consolidate per-cell documentContext into notebook-level metadata. - Updated `extension.ts` to include the new migration function. - Enhanced `migrationUtils.ts` with logic to handle hoisting and ensure idempotency. - Added tests to validate the migration behavior and ensure consistent handling of documentContext across cells. - Updated type definitions to include new metadata fields for originalFileName and importContext.
- Updated `createTempNotebook` function to use the workspace folder path as the base directory for temporary notebook files instead of the system's temporary directory. - This change ensures that temporary files are created within the context of the current workspace, improving organization and accessibility.
- Added importContext to various importer forms and cell metadata functions, consolidating file-related information such as fileName, originalFileName, fileSize, and importTimestamp. - Removed redundant documentContext from cell metadata to streamline data handling. - Ensured consistent implementation across audio, biblica, docx, ebibleCorpus, indesign, macula, markdown, obs, pdf, plaintext, recursiveTextSplitter, spreadsheet, subtitles, tms, and usfm importers.
…e-ben-update hoist metadata
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| console.warn(`[USFM Export] Skipping ${fileName} - not imported with USFM importer (importerType: ${importerType}, corpusMarker: ${corpusMarker})`); | ||
| vscode.window.showWarningMessage(`Skipping ${fileName} - not imported with USFM importer`); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
USFM export validation mismatches detection criteria
Medium Severity
The USFM file detection logic (lines 1280-1292) routes files to the USFM exporter based on several criteria: importerType === 'usfm', NT/OT corpus markers with USFM file extensions, or any file with a .usfm/.sfm extension. However, the export function's validation (line 906) only accepts files where importerType === 'usfm-experimental' OR corpusMarker === 'usfm'. Files detected through the other criteria (like importerType === 'usfm' or NT/OT with USFM extension) will be routed to the exporter but then skipped with a warning, effectively failing silently.
Additional Locations (1)
…ferences in metadata - Updated the JSON and spreadsheet importers to generate unique UUIDs for each cell ID instead of relying on legacy naming conventions. - Introduced global references in the metadata structure for both JSON and spreadsheet cells, allowing for better tracking and linking of content. - Refactored the handling of global references in the spreadsheet importer to improve alignment and mapping of imported content. - Adjusted type definitions to reflect changes in column mapping and metadata structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All importers now use global references, new UUIDs and milestones.
Note
Adds new export capability and aligns metadata/importers with global references and UUIDs.
exportUsfmRoundtripwithlineMappingswhen available.globalReferences, UUIDs, and milestones; updates exporter to merge segmented paragraphs, enforce UTF‑8, and preserve unmodified IDML resources.importContext; addssaveFilecommand to provider.documentContextintometadata.importContext, promotes consistentimporterType/originalFileName; adds tests; stops normalizingcorpusMarker; improves MaculafileDisplayNamehandling.originalFileNameandimportContext; export UI lists USFM; plugin selection shows “in BETA”; improves webview refresh matching.Written by Cursor Bugbot for commit d015813. This will update automatically on new commits. Configure here.