-
Notifications
You must be signed in to change notification settings - Fork 2
chore: Update docs workflow to sync docker-compose #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d42fb45
7d35f93
4d91ce2
2073c55
05668bd
7bdc20e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why delete the alloy configuration? I understand that we want telemetry from all users, I wouldn't remove it
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because it is not shown in the validator guide, here we only store what is shown there. The day we start showing it, we add it, or we remove the removal |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # Sanitize docker-compose.yaml for documentation | ||
| # Removes the alloy service and volumes section | ||
| # Usage: sanitize-docker-compose.sh <docker_compose_file> | ||
|
|
||
| DOCKER_COMPOSE_FILE="$1" | ||
|
|
||
| if [[ -z "$DOCKER_COMPOSE_FILE" ]]; then | ||
| echo "Usage: $0 <docker_compose_file>" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ ! -f "$DOCKER_COMPOSE_FILE" ]]; then | ||
| echo "File not found: $DOCKER_COMPOSE_FILE" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Sanitizing docker-compose file: $DOCKER_COMPOSE_FILE" | ||
|
|
||
| # Use yq to remove alloy service and volumes section | ||
| yq -i 'del(.services.alloy) | del(.volumes)' "$DOCKER_COMPOSE_FILE" | ||
|
|
||
| # Remove leftover comments about alloy (yq preserves them) | ||
| sed -i '/# Grafana Alloy/,/^[^ #]/{ /^[^ #]/!d }' "$DOCKER_COMPOSE_FILE" | ||
| sed -i '/^$/N;/^\n$/d' "$DOCKER_COMPOSE_FILE" | ||
|
|
||
| echo "Docker-compose sanitization completed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update stale comment about docker-compose sanitization implementation
The docker-compose prep step calls
.github/scripts/sanitize-docker-compose.sh, which usessed, but the comment still says “using yq”.You can align the comment with the implementation:
📝 Committable suggestion
🤖 Prompt for AI Agents