Skip to content

Conversation

@msom
Copy link
Contributor

@msom msom commented Aug 21, 2025

Adds support for Python 3.13.

Python 3.13 removed logging._acquireLock and logging._releaseLock. Changed it to use logging._lock, which is available since Python 3.7, see for example this PR. Also added a small test to ensure this code is actually run, but testing the actual functionality of base_config with all it's different parameter combinations is still missing.

Also update the (dev) packages to the latest version and unpin them.

See also https://github.com/geoadmin/infra-terraform-bgdi/pull/1145

@github-actions github-actions bot changed the title PB-1920: Add support for python 3.13 PB-1920: Add support for python 3.13 - #minor Aug 21, 2025
@msom msom requested a review from ltshb August 21, 2025 07:04
@msom
Copy link
Contributor Author

msom commented Aug 21, 2025

@ltshb what do you think: Should we keep Python <3.7 compatibility? This would require doing some differentiation for the logging lock. Removing compatibility on the other hand would us allow to remove such differentiation but we should probably make this then a major relase?

@ltshb
Copy link
Contributor

ltshb commented Aug 21, 2025

@ltshb what do you think: Should we keep Python <3.7 compatibility? This would require doing some differentiation for the logging lock. Removing compatibility on the other hand would us allow to remove such differentiation but we should probably make this then a major relase?

It depends if the support of 3.7 is very easy and don't require much code lines, might make sense to keep it for a little while, 3.7 has reached EOL since mid 2023, so keeping it for a few years after EOL would be nice, but if the support add too much complexity I would drop it and make a major release.

@msom msom force-pushed the feat-PB-1920-python3.13 branch from 3dfd22b to f643e26 Compare August 21, 2025 07:56
@msom
Copy link
Contributor Author

msom commented Aug 21, 2025

@ltshb what do you think: Should we keep Python <3.7 compatibility? This would require doing some differentiation for the logging lock. Removing compatibility on the other hand would us allow to remove such differentiation but we should probably make this then a major relase?

It depends if the support of 3.7 is very easy and don't require much code lines, might make sense to keep it for a little while, 3.7 has reached EOL since mid 2023, so keeping it for a few years after EOL would be nice, but if the support add too much complexity I would drop it and make a major release.

Yes, this is easy, I changed it accordingly.

@msom msom merged commit 629a983 into master Aug 21, 2025
3 checks passed
@msom msom deleted the feat-PB-1920-python3.13 branch August 21, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants