Convert sentry_sdk type annotations into the modern format #5206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts all Python 2-style type annotations (in comments) into Python 3-style annotations (after
:tokens, and inside the AST).There's a large amount of changes in here, apologies for that. I generated these changes using:
uv run --with libcst python -m libcst.tool codemod convert_type_comments.ConvertTypeComments --no-format -j1 sentry_sdkuvx com2ann sentry_sdkuvx ruff format sentry_sdkManual changes
foo = None # type: Foo # noqaintofoo: "Foo # noqa" = None, which were trivial to fixfoo = None # type: Foointofoo: Foo = None, mypy starts raising an error on the second form - I suppressed these usingtype: ignore[assignment]Test plan
mypyshould continue being green, as evidenced by runninguvx tox -e linters