fix: disable regex nosubs|optimize flags on MSVC #17831
Open
+8
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #17786 where models with complex tokenizer patterns (e.g.,
gpt-4o) fail to load on Windows/MSVC witherror_stack.MSVC's
std::regexhas severe stack limitations with nested lookaheads. Thenosubs | optimizeflags exacerbate this, causing failure during pattern compilation.This PR uses
#ifdef _MSC_VERto apply the flags only on platforms where they're beneficial (GCC/Clang on Linux/macOS) while preserving the original behaviour on Windows.Closes #17830