Skip to content

Conversation

@nixpanic
Copy link

There is no need to bind-mount /dev when the container is privileged,
the container runtime provides everything in /dev that Gluster expects.

Fixes: https://bugzilla.redhat.com/1651270

There is no need to bind-mount /dev when the container is privileged,
the container runtime provides everything in /dev that Gluster expects.
@nixpanic
Copy link
Author

See-also: gluster/gluster-kubernetes#538

Copy link
Member

@SaravanaStorageNetwork SaravanaStorageNetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn
Copy link

I wonder if there are obscure or old runtimes that did not mount /dev automatically for a privleged container. If that's the case perhaps we could add a line to the containers start scripts to refuse to run if it fails to find a populated /dev.
This could possibly be done in a followup.

@humblec
Copy link

humblec commented Nov 30, 2018

@SaravanaStorageNetwork @nixpanic Do you guys have any document ( may be from docker itself ?) which kind of explain the behaviour with priviledged and /dev/ access ? If yes, could you please share it ?

@nixpanic
Copy link
Author

nixpanic commented Dec 3, 2018 via email

@phlogistonjohn
Copy link

phlogistonjohn commented Dec 4, 2018

Does it make sense to reach out to the crio project and ask for more detailed descriptions of this behavior? Does that project have a mailing list or maybe we should just create an issue at the cri-o github project? I'd be happy to help if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants