Additions, improvements #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifohancroft
suggested changes
Dec 18, 2024
| **Screenshot** | ||
|
|
||
|  | ||
|  |
Contributor
There was a problem hiding this comment.
This is incorrect. It should lead to the screenshot in the original repo.
|
|
||
| - easily process multiple files and folders right from your file manager | ||
| - preview your documents in your default PDF viewer and file manager before editing them | ||
| - preview your documents in your default PDF viewer before editing them |
Contributor
There was a problem hiding this comment.
Obviously, I'm not the maintainer but I don't think removing the browse button is a good idea.
|
|
||
| sudo apt install libimage-exiftool-perl yad qpdf | ||
|
|
||
| If you do not have Gnome installed, you may need `gir1.2-gnomedesktop-3.0` and `gir1.2-gnomedesktop-4.0` for thumbnail generation. |
Contributor
There was a problem hiding this comment.
Perhaps find a way to implement the feature without it depending on Gnome?
Contributor
|
P.S. Implementing multiple unreleated features in a single PR is a bad idea and a frowned upon practice. Please submit separate PRs for the separate features. Disclaimer: I'm not the maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added backup way of finding thumbnails that works on non-gnome system
Added clobbering check for automatic renaming based on metadata
Added optional large thumbnails for PDF files if poppler-utils and imagemagick are present
Added check for OCR layer (using poppler-utils) and checkbox to perform OCR on exit (using ocrmypdf)
Removed "open folder" button (because I was getting lost in what form field went where trying to add one)
Added new screenshot with large preview and OCR button