Skip to content

Do not extract strings from external dependencies #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abakum wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −1
Open

Do not extract strings from external dependencies #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8d08e3
Keep Position
abakum Dec 4, 2025
40236fe
Do not extract strings from external dependencies
abakum Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions message/pipeline/extract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,16 @@ func (px packageExtracter) addMessage(
comment string,
arguments []argument) {
x := px.x

// Do not extract strings from external dependencies,
// as their files are located in the module cache.
if file := x.conf.Fset.File(pos); file != nil {
filename := filepath.ToSlash(file.Name())
if strings.Contains(filename, "/pkg/mod/") {
return
}
}

fmtMsg := constant.StringVal(c)

ph := placeholders{index: map[string]string{}}
Expand Down
2 changes: 1 addition & 1 deletion message/pipeline/pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ func (s *State) Merge() error {
for _, orig := range filtered {
m := *orig
m.Key = ""
m.Position = ""
// m.Position = ""

for _, id := range m.ID {
if t, ok := translations[tag][id]; ok {
Expand Down