-
Notifications
You must be signed in to change notification settings - Fork 108
Add EATT Support #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add EATT Support #836
Conversation
|
Using this PR as a discussion thread. @barbibulle Client-side implementation of EATT is quite easy, while the server side is much more complicated, because Some solutions I come up:
|
|
Another problem is that A workaround could be to introduce Protocols like class EnhancedBearer(Protocol):
connection: Connectionso that isinstance can just check if bearer is enhanced. Still, this may make users hard to cast the actual type. Or we can still pass actual classes as signatures, and only use protocols to determine types inside Bumble. |
|
Maybe a simple option is to continue using |
Good idea. Let's use this structure first, and if we really need per-channel request we can still add them in the future. |
|
I found that we still need another class - since at least CCCD needs per-bearer control. |
bb85d59 to
28d7d19
Compare
6d1a60f to
d617ea0
Compare
No description provided.