Skip to content

Conversation

@GHOryy5
Copy link

@GHOryy5 GHOryy5 commented Dec 9, 2025

The Issue
In CheckChange, the code ignores the error from SendSignal and returns ERESTARTSYS.
In Linux, TIF_SIGPENDING is set unconditionally, ensuring the loop breaks.
In gVisor, if SendSignal fails, no signal is pending. Returning ERESTARTSYS causes the syscall to restart immediately, leading to an infinite loop (DoS).

The Fix
I added an error check. If SendSignal fails, we return EIO to abort the syscall safely.

@google-cla
Copy link

google-cla bot commented Dec 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Handle signal queuing failure to prevent infinite loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant