Skip to content
This repository was archived by the owner on Jun 12, 2024. It is now read-only.

Conversation

@nouiz
Copy link

@nouiz nouiz commented Sep 3, 2015

DO NOT MERGE YET.

I got by email some fix to this code that I added in my repo in a commit. The change is one line. I'm contacting the author of that fix.

If I don't get an answer, I think that I could tell you which method it is and you could try to fix it?

fix gh-99

@nouiz
Copy link
Author

nouiz commented Sep 3, 2015

I added the fix. I got an confirmation that it is ok.

@shields
Copy link
Contributor

shields commented Sep 3, 2015

Our lawyers won't let me merge the other person's change, even a single-line change, unless they also accept the CLA. I'm sorry; it is annoying.

Maybe it's best if you tell me about that change and I write the one line.

@nouiz
Copy link
Author

nouiz commented Sep 4, 2015

The method __contains__ of the class _BaseNet don,t always return the good answer. It probably miss tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I speed up your project in my clone repository

3 participants