Skip to content
This repository was archived by the owner on May 27, 2024. It is now read-only.

Conversation

@rogers0
Copy link

@rogers0 rogers0 commented Jun 30, 2013

Dear Thomas,

You "NameBench" is really good! Thank you for your effort!

However, I find that the quality of a DNS server doesn't only rely on the speed of result return, but also the result itself.
For example a DNS respond each request in less than 10ms, but it always return the resolving result in US, so APAC/EU user will still find slow to access the internet. This is particular noticeable when accessing CDN server, such as akamai or cloudfront.

So I made this changes to your "NameBench" script. Currently it only shows the result of Min/Avg/Max result for each nameserver, and it's not reflected in the final sorted result, because I think the DNS response time and ping time to the CDN host cannot simply be added and compared.

If you like my idea, please just pull.
And feel free to contact me if you have any comment.

Thank you!

Cheers,
Roger

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import order, os should be before re (alpha)

@rogers0
Copy link
Author

rogers0 commented Jul 1, 2013

Dear sww-goog,

Thank you so much for reviewing my patch!

For the import order and typo, I already fixed/committed in my branch.
For the space indention, I think it's okay because it's a "third-party" library and not necessary to be the same as main branch.
BTW. This "third-party" lib is maintained under another of my repo: https://github.com/rogeryan0/shell_ping/

If you have further comment, just let me know. Thank you!

Cheers,
Roger

@ghost ghost assigned tstromberg Oct 5, 2013
@tstromberg
Copy link
Contributor

Hey Roger.

Your absolutely correct about how important CDN performance is. I've long been thinking about measuring it in namebench, but had not sat down to make it happen. Anyways, I love your idea, and plan to port it to the next version of namebench. I'm somewhat hesitant to use ICMP latency as a benchmark, as it is sometimes unavailable through NAT's. What do you think about using a small HTTP request to the CDNs instead?

For 2.0, this bit of the code base will be rewritten in Go, but the concept should be fairly straight forward for me to port over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants