ui: Configure search to work on arbitrary slice-like tracks #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently searching only works on tracks with the 'SLICE_TRACK_KIND' kind tag, which was required for the previous search mechanism. Now, any tracks can be searched as long as they have name / args_set_id fields. This patch replaces the SLICE_TRACK_KIND with two new kinds tags: - SLICE_TRACK: Indicates that this track represents slice like events where ts, dur, name and args_set_id mean what you'd expect, but the ids do not necessarily correspond to ids in the slice table. - SLICE_TABLE_TRACK: Subset of SLICE_TRACK where ids correspond to the relevant slices in the slice table. Change-Id: I174695fedf1f4e353cbf8532cb6d9efdb5261f71
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-20098459597-1-ui/ui/index.html |
aMayzner
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently searching only works on tracks with the 'SLICE_TRACK_KIND' kind tag, which was required for the previous search mechanism. Now, any tracks can be searched as long as they have name / args_set_id fields.
This patch replaces the SLICE_TRACK_KIND with two new kinds tags:
All tracks that used to have kind SLICE_TRACK_KIND now have both ['SLICE_TRACK', and 'SLICE_TABLE_TRACK'].
Debug tracks now have only 'SLICE_TRACK', so search can now work on them.