sdk: Add ClearIncrementalState method to data source traits #4160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new optional ClearIncrementalState method to data source traits that allows clearing incremental state without destroying and recreating the state object. This is useful for data sources like track event that use large data structures (e.g., hash maps) which are expensive to reallocate. We also plumb this feature through to the C and Rust SDKs in the appropriate ways for each of them.
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-20735487000-1-ui/ui/index.html |
sashwinbalaji
approved these changes
Dec 19, 2025
dreveman
reviewed
Dec 19, 2025
Member
Author
|
Thanks both! All comments should be addressed. |
dreveman
reviewed
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new optional ClearIncrementalState method to data
source traits that allows clearing incremental state without destroying
and recreating the state object. This is useful for data sources like
track event that use large data structures (e.g., hash maps) which are
expensive to reallocate.
We also plumb this feature through to the C and Rust SDKs in the
appropriate ways for each of them.
We also implement this for the TrackEvent Data sources: this should
significantly reduce the amount of memory allocations when aggressive
intern clearing is enabled.