-
Notifications
You must be signed in to change notification settings - Fork 135
deps: update opentelemetry.version to v1.57.0 #4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deps: update opentelemetry.version to v1.57.0 #4255
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's OpenTelemetry dependency to version 1.57.0. This routine maintenance ensures the project benefits from the latest features, performance optimizations, and bug fixes provided by the OpenTelemetry Java SDK, enhancing observability capabilities and system stability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the opentelemetry.version property in the benchmarks/pom.xml to 1.57.0. While this is a straightforward dependency update, it highlights a potential issue with dependency management in the project. The benchmarks module defines its own OpenTelemetry version, which can lead to inconsistencies with other modules and within the module itself, as not all OpenTelemetry dependencies use this property. I've left a comment with more details and suggestions for how to resolve this to prevent potential runtime issues.
| <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
| <junixsocket.version>2.10.1</junixsocket.version> | ||
| <opentelemetry.version>1.56.0</opentelemetry.version> | ||
| <opentelemetry.version>1.57.0</opentelemetry.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version property override in the benchmarks module can cause dependency conflicts.
- Internal inconsistency: The
opentelemetry-apiandopentelemetry-contextdependencies (lines 43-49) in this file do not use this version property. They will resolve to the version in the parent BOM, while the SDK artifacts use this new version. This can lead to runtime errors if the API and SDK versions are incompatible. - External inconsistency: The
benchmarksmodule depends ongoogle-cloud-spanner, which uses the OpenTelemetry version from the parent BOM. Overriding the version here can lead to having two different versions of OpenTelemetry on the classpath during benchmark execution.
Recommendation:
To ensure consistent dependency versions across the project, it would be best to remove this local opentelemetry.version property and let all OpenTelemetry dependencies be managed by the parent dependencyManagement. If overriding is necessary for benchmarks, please ensure all io.opentelemetry artifacts in this file use this property for consistency.
This PR contains the following updates:
1.56.0->1.57.01.56.0->1.57.01.56.0->1.57.01.56.0->1.57.0Release Notes
open-telemetry/opentelemetry-java (io.opentelemetry:opentelemetry-sdk-testing)
v1.57.0API
GlobalOpenTelemetry#getOrNoop,#isSet. Update#getto always returns obfuscated instance(#7819)
Incubating
(#7814)
SDK
Logs
(#7529)
Exporters
(#7701)
(#7840)
(#7881)
(#7884)
Extensions
(#7866)
(#7821)
Project tooling
(#7841)
(#7845)
(#7846)
(#7852)
(#7867)
(#7868)
(#7886)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.