Skip to content

fix: close write object stream always #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandra-siri merged 1 commit into from
Dec 11, 2025
Merged

fix: close write object stream always #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/cloud/storage/_experimental/asyncio/async_appendable_object_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,8 @@ async def close(self, finalize_on_close=False) -> Union[int, _storage_v2.Object]
await self.finalize()
else:
await self.flush()
await self.write_obj_stream.close()

await self.write_obj_stream.close()

self._is_stream_open = False
self.offset = None
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/asyncio/test_async_appendable_object_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ async def test_finalize_on_close(mock_write_object_stream, mock_client):
result = await writer.close(finalize_on_close=True)

# Assert
mock_stream.close.assert_not_awaited() # Based on new implementation
mock_stream.close.assert_awaited_once()
assert not writer._is_stream_open
assert writer.offset is None
assert writer.object_resource == mock_resource
Expand Down