chore: Prevent OS Login key accumulation in e2e tests

[chandra-siri]

chore: Prevent OS Login key accumulation in e2e tests

[gemini-code-assist]

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the e2e test suite where repeated gcloud SSH commands would lead to an accumulation of SSH keys in the OS Login profile. The changes introduce a robust key management strategy: a single SSH key is generated for the duration of the build, used consistently for all VM interactions, and then meticulously removed from the OS Login profile upon completion. This ensures a cleaner and more stable test environment.

Highlights

• SSH Key Generation: A new step has been added to generate a persistent SSH key at the beginning of the Cloud Build process. This key is used for all subsequent SSH and SCP operations to the test VM.
• Consistent SSH Usage: All gcloud compute ssh and gcloud compute scp commands within the e2e tests now explicitly use the newly generated SSH key, ensuring a consistent and controlled authentication mechanism.
• OS Login Key Cleanup: A cleanup step has been introduced to remove the generated SSH key from the OS Login profile after the tests are completed. This prevents the accumulation of temporary SSH keys in the profile over time.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a good solution to prevent SSH key accumulation in the OS Login profile during e2e tests by generating a persistent key for each build run. The implementation is solid, creating the key, using it for all SSH/SCP commands, and cleaning it up afterwards. I've identified a potential race condition due to a missing explicit dependency in a waitFor block, which should be addressed. I also have a suggestion to simplify the script by removing a redundant file copy. Overall, great work on improving the test infrastructure.

[chandra-siri]

3.14 support is recently added , it's still not stable yet. KMS tests are failing which can be ignored for this PR

@googlyrahman , @Mahalaxmibejugam