Fixed crashes when picking apps to run for diff/merge/view #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easiest fix was to pass in FALSE for whether to use the 'new' Vista-style file dialogues
ignore dependencies/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could never pick an external app to run for diff/merge/view - it would crash in ucrtbase.dll inside the file picker. Some quick searching pointed to CoUninitialize() calls being the culprit - CFileDialog::~CFileDialog() has one call to CoUninitialize(), but only if you are using a Vista-style dialogue.
The simplest fix was to pass in FALSE for whether to use the 'new' Vista-style file dialogues.
If you are passionate about the new Vista-style dialogues, this isn't the right fix.