Modify: optimize code structure #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoxia
changed the title
src/Feedback.php
Outdated
| class Feedback implements \JsonSerializable | ||
| { | ||
| public function __construct( | ||
| public string $feedback_type, |
There was a problem hiding this comment.
constructor property promotion has been introduced in php 8 but composer.json allow you to use 7.4
Author
There was a problem hiding this comment.
Sorry, I overlooked this point. Thank you for the reminder. I will handle it as soon as possible.
src/Feedback.php
Outdated
| { | ||
| public function __construct( | ||
| public string $feedback_type, | ||
| public string $user_id, |
There was a problem hiding this comment.
Also I think camelCase is much common now than snake_case
Author
There was a problem hiding this comment.
Regarding this, the current coding style is being maintained as much as possible to prevent compatibility issues. The implementation of camel case naming will be considered in future major versions.
Contributor
|
感谢，但是似乎需要修复一下UT |
Author
好的，这两天内处理。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
大佬，让我来负责 PHP SDK 开发吧 🤣！