fix heap use after free when terminating and pass CXXFLAGS to linker #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the heap use after free we had applied locally when searching for memleaks a few days ago, but I guess the change went missing somehow. pass CXXFLAGS to the linker, when building with -fsanitize=address,undefined linking fails otherwise
Closed
Owner
graphitemaster
left a comment
graphitemaster
left a comment
There was a problem hiding this comment.
The reason I didn't pass CXXFLAGS is because then Neothyne get's linked against libsupc++ which I've been trying to avoid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the heap use after free we had applied locally when searching for memleaks a few days ago, but I guess the change went missing somehow.
pass CXXFLAGS to the linker, when building with -fsanitize=address,undefined linking fails otherwise