-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Summary
The CasaOS converter sets package_name in metadata.yaml, but this field is deprecated and ignored by the loader. This field should be removed from the converter output.
Background
The package naming system works as follows:
app_idis derived from the directory name (e.g.,2fauth)--prefixis passed at build time (e.g.,--prefix casaos)package_nameis computed:{prefix}-{app_id}-container→casaos-2fauth-container
The deprecated package_name field in converter output serves no purpose and should be removed.
Solution
Remove package_name from the CasaOS converter output in transformer.py.
The build script in halos-imported-containers will be updated separately to pass --prefix "$source_name" to generate-container-packages.
Files to Modify
src/generate_container_packages/converters/casaos/transformer.py- Removepackage_namefrom outputtests/converters/casaos/test_transformer.py- Update tests to not expectpackage_name
Related
- Part of Container lifecycle conventions: Docker-managed restarts and journald logging halos-distro#49 (Container lifecycle conventions)
- Companion fix in halos-imported-containers: add
--prefixto build script
Metadata
Metadata
Assignees
Labels
No labels