Skip to content

fix(casaos): set app_id with prefix in converter output, remove deprecated package_name #126

@mairas

Description

@mairas

Summary

The CasaOS converter sets package_name in metadata.yaml, but this field is deprecated and ignored by the loader. This field should be removed from the converter output.

Background

The package naming system works as follows:

  1. app_id is derived from the directory name (e.g., 2fauth)
  2. --prefix is passed at build time (e.g., --prefix casaos)
  3. package_name is computed: {prefix}-{app_id}-containercasaos-2fauth-container

The deprecated package_name field in converter output serves no purpose and should be removed.

Solution

Remove package_name from the CasaOS converter output in transformer.py.

The build script in halos-imported-containers will be updated separately to pass --prefix "$source_name" to generate-container-packages.

Files to Modify

  • src/generate_container_packages/converters/casaos/transformer.py - Remove package_name from output
  • tests/converters/casaos/test_transformer.py - Update tests to not expect package_name

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions