-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Overview
Remove hard-coded halos.local hostname references from E2E test files to comply with the workspace hostname policy.
Tracking issue: hatlabs/halos-distro#61
Violations
Multiple E2E test files have hard-coded URLs:
compare-layouts.jsfrontend/playwright.config.tsfrontend/test/e2e/simple-screenshot.mjsfrontend/test/e2e/test-css-loading.mjsinspect-html.jstest-dark-theme.jstest-fresh.jstest-layout.jstest-storage-layout.jstest-tabs.js
Fix
- playwright.config.ts: Read
baseURLfrom environment variableHALOS_TEST_URL - All test files: Use the configured baseURL from Playwright config or read from environment
Example fix for playwright.config.ts:
export default defineConfig({
use: {
baseURL: process.env.HALOS_TEST_URL || 'https://localhost:9090',
},
});Enforcement
A pre-commit hook has been added. Run .github/scripts/check-hardcoded-hostnames.sh to verify.
Metadata
Metadata
Assignees
Labels
No labels