-
Notifications
You must be signed in to change notification settings - Fork 90
Add graphical language configuration option #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Master92 I think you need to leave this in English, because there is no need to translate that, and when you change settings on VTX it will say you in English to change Bandwith of googles to Wide or Narrow, and with translation it could be confusing Some fixes: |
|
@lesharodin Thanks for your input. However, I'd not include them in this PR because they don't directly relate to my changes. You could open a new PR with those fixes so they can be discussed and applied separately. |
|
The language option needs some special handling, showing "English" in English, "Chinese" in Chinese, and "Russian" in Russian. |
|
in my oppinion, the "Language" selection should always be in english. That way you can find the setting again when you accidentially changed the language and can no longer read the word "language". |
This partly reverts 0df01b7
4e0429a to
f896e32
Compare
|
Force-pushed to rebase onto current |
I'm sorry that I didn't respond and work on this for so long - life you know? |
This PR re-applies changes by @ligenxxxx i.e. it adds a drop-down configuration box of the current UI language in the firmware page. I tried to localize as much as possible but need some help translating the strings in lines 250 and 251 of the ini files to Russian and Chinese. Maybe @Sat1l and @ligenxxxx might want to help me out there?
Another thing I added was automatical removal of the text file used to configure the UI language once it has been applied. This way, you can still initially configure the language from an SD card file while also being able to change it in the application afterwards.
English



Chinese
Russian